fix: resolve AI Chat crash and hang during streaming on macOS 15.x#860
Merged
fix: resolve AI Chat crash and hang during streaming on macOS 15.x#860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #852
Summary
"bottomAnchor"(1pt fixed view) instead of streaming message whose height changes every flush.fixedSize(horizontal: false, vertical: true)fromAIChatMessageView— redundant inLazyVStackand forces expensive re-measurement on every content flushSet<UUID>outsideForEachto replace O(n)firstIndexper visible message per frameisUserScrolledUpon conversation switch to prevent stale scroll stateRoot cause
On macOS 15.2, three sources compete for scroll position during streaming: (1) animated
scrollTotargeting a growing message, (2) the user's scroll gesture, (3)LazyVStackrecalculating layout from height changes forced by.fixedSize. This triggers anNSScrollViewlayout assertion. Apple fixed the framework issue in later macOS versions, which is why it doesn't reproduce on macOS 26.Test plan
.fixedSizeremoval)